-
Notifications
You must be signed in to change notification settings - Fork 312
[WIP] Added Longest Common Sequence #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Please go through some already present code in |
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
=============================================
+ Coverage 98.866% 98.874% +0.008%
=============================================
Files 25 25
Lines 2999 3021 +22
=============================================
+ Hits 2965 2987 +22
Misses 34 34
|
LCS with Back Tracking Done |
These issues still persist in code. Please make function name more informative and follow numpy docstring guidelines. |
|
@@ -546,3 +547,54 @@ def bucket_sort(array: Array, **kwargs) -> Array: | |||
if _check_type(array, DynamicArray): | |||
array._modify(force=True) | |||
return array | |||
|
|||
def LCS(data_A,data_B): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def LCS(data_A,data_B): | |
def lowest_common_subsequence(seq1, seq2): |
Care to add some spaces around |
It has conflicts now. Please resolve them. |
Closing in favour of #315 |
References to other Issues or PRs or Relevant literature
Fixes #308 #310
Brief description of what is fixed or changed
Longest Common Subsequence #308 is been added with backtracking
so now we get the Lenght of LCS and sequence too
Other comments