Skip to content

Conversation

amureki
Copy link
Collaborator

@amureki amureki commented Jun 28, 2023


via GIPHY

@amureki amureki requested a review from codingjoe June 28, 2023 14:27
@amureki amureki self-assigned this Jun 28, 2023
@amureki amureki force-pushed the you-are-terminated branch from c19b0d8 to 77ac2b0 Compare June 28, 2023 14:48
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.14 ⚠️

Comparison is base (da01823) 98.00% compared to head (77ac2b0) 97.86%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #83      +/-   ##
==========================================
- Coverage   98.00%   97.86%   -0.14%     
==========================================
  Files          17       17              
  Lines         701      703       +2     
==========================================
+ Hits          687      688       +1     
- Misses         14       15       +1     
Impacted Files Coverage Δ
joeflow/tasks/machine.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@codingjoe codingjoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @amureki, excellent find!

Nickcage What GIF by LIPPERT

@codingjoe codingjoe merged commit d75d27c into main Jun 29, 2023
@codingjoe codingjoe deleted the you-are-terminated branch June 29, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants