Skip to content

fix: better url mapping vxtwitter🧵 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2023
Merged

fix: better url mapping vxtwitter🧵 #23

merged 1 commit into from
Jul 18, 2023

Conversation

Yanzi-dev
Copy link
Contributor

Summary:

This pull request aims to enhance the handleGuildMessageCreation function by introducing a more flexible URL mapping system. The URLs and their corresponding replacements are externalized, allowing for easy modification and extension without modifying the function itself.

Changes Made:

  • Moved the URL mapping definitions outside the handleGuildMessageCreation function.
  • Created an array called urlMappings to hold the URL patterns and replacements.
  • Modified the function to iterate over the urlMappings array and apply the corresponding replacements to the message content.
  • Improved code readability and maintainability.

@neolectron neolectron changed the title fix better url mapping vxtwitter🧵 fix: better url mapping vxtwitter🧵 Jul 18, 2023
@neolectron neolectron merged commit b0767d8 into codinglab-io:master Jul 18, 2023
potb pushed a commit that referenced this pull request Aug 2, 2023
potb pushed a commit that referenced this pull request Jan 5, 2024
potb pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants