feat: add quoi-feur game with react #31

luca-montaigut · 2023-08-02T23:34:34Z

Feature quoi-feur :

slash command /quoi-feur :
- add => add game to current channel
- remove => remove game from current channel

Le jeu :

detection of "quoi" at the end of the sentence
response in emoji (in 'react' for non-boomers), with a random draw:

-> 19 on 20 : react 🇫 🇪 🇺 🇷

-> 1 on 20 : react 🇨 🇴 🇺 🇧 🇪 🇭 🔇 and mute the author for 5 minutes

neolectron

I like the idea, however we should be careful with the state of each features before merging.

.env.example

src/quoi-feur.ts

Co-authored-by: Peïo Thibault <[email protected]>

src/helpers/regex.helper.ts

src/quoi-feur.ts

neolectron

Good changes! Made me notice some of the limitation we have with the core as it is now.

Don't forget that any feature in addition of being stateless should work for any number of instance the bot is invited in.

neolectron · 2023-09-04T15:14:07Z

src/helpers/regex.helper.ts

@@ -1,6 +1,15 @@
 const socialNetworksUrlRegex = new RegExp(
  '^(https?://)?(www.)?(facebook.com|fb.me|twitter.com|vxtwitter.com|instagram.com|linkedin.com|youtube.com|youtu.be|pinterest.com|snapchat.com|tiktok.com)/[a-zA-Z0-9.-/?=&#_]+$',
 );
+const punctuationRegex = new RegExp(/[.,!?]/g);
+const emojiRegex = new RegExp(/(\p{Extended_Pictographic}|\p{Emoji_Component})/gu);
+const quoiDetectorRegex = new RegExp(/\b\s*[q][u][o][i]\s*$/i);


While punctuationRegex and emojiRegex can make sense as global helpers, I don't think there's a lot of use-cases for other modules to detect sentences that ends with quoi.

Can you move this inside your module helper please ?

neolectron · 2023-09-04T15:14:22Z

src/helpers/regex.helper.ts

+
+export const removePunctuation = (text: string) => text.replaceAll(punctuationRegex, '');
+export const removeEmoji = (text: string) => text.replaceAll(emojiRegex, '');
+export const endWithQuoi = (text: string) =>


same as above - should be in module helpers.

neolectron · 2023-09-04T15:32:09Z

src/modules/quoiFeur/quoiFeur.module.ts

+        )
+        .toJSON(),
+      handler: {
+        add: async (interaction) => {


You don't need to wrap this inside an arrow-function, you can pass directly addQuoiFeurToChannel to add.

Whenever a command throw/crash, it already prints out to the console as an error, so the .catch is unnecessary.

Same with remove below.

neolectron · 2023-09-04T15:36:18Z

src/modules/quoiFeur/quoiFeur.module.ts

+    },
+  ],
+  eventHandlers: {
+    ready: async (client) => {


Same as above, you should pass directly deleteRoleMutedByBot here.
(See other review to understand the signature change)

neolectron · 2023-09-04T15:38:48Z

src/modules/quoiFeur/quoiFeur.helpers.ts

+  );
+};
+
+export const deleteRoleMutedByBot = async (guild: Guild | null): Promise<void> => {


This shouldn't depend on a specific guild but rather run for any guild the bot is in.

So I recommend to remove the role for every guild the bot is in.
(otherwise if you invite the same bot instance to another server it won't work)

I think you can change the signature of this and take a Client as input instead, so you can map it to the ready event directly.

(or even code it inline if you want)

luca-montaigut force-pushed the quoi-feur branch 2 times, most recently from acce502 to 1d6dc49 Compare August 2, 2023 23:56

neolectron requested changes Aug 9, 2023

View reviewed changes

.env.example Outdated Show resolved Hide resolved

src/quoi-feur.ts Outdated Show resolved Hide resolved

src/quoi-feur.ts Outdated Show resolved Hide resolved

src/quoi-feur.ts Outdated Show resolved Hide resolved

potb mentioned this pull request Aug 12, 2023

feat: blacklist feur word #30

Closed

feat: add quoi-feur game with react

012896d

luca-montaigut force-pushed the quoi-feur branch 4 times, most recently from 250fb5e to 8e8836c Compare September 1, 2023 12:22

feat: remove role env var

b4ac595

luca-montaigut force-pushed the quoi-feur branch from 8e8836c to b4ac595 Compare September 1, 2023 13:29

feat: make quoi-feur stateless

6879106

luca-montaigut requested review from neolectron and potb September 1, 2023 14:36

feat: add and remove game from channel

cbffe77

luca-montaigut force-pushed the quoi-feur branch from 3288b14 to cbffe77 Compare September 1, 2023 14:38

fix: avoid error if user delete message before react end

7486ef9

luca-montaigut force-pushed the quoi-feur branch from 5b55490 to 7486ef9 Compare September 1, 2023 14:52

potb reviewed Sep 1, 2023

View reviewed changes

src/quoi-feur.ts Outdated Show resolved Hide resolved

src/quoi-feur.ts Outdated Show resolved Hide resolved

fix: detail one minute constant

e065591

Co-authored-by: Peïo Thibault <[email protected]>

luca-montaigut force-pushed the quoi-feur branch from 165952b to 0fb51e0 Compare September 1, 2023 21:32

github-advanced-security bot found potential problems Sep 1, 2023

View reviewed changes

src/helpers/regex.helper.ts Fixed Show fixed Hide fixed

luca-montaigut force-pushed the quoi-feur branch from 0fb51e0 to 33abbff Compare September 1, 2023 21:37

github-advanced-security bot found potential problems Sep 1, 2023

View reviewed changes

src/helpers/regex.helper.ts Fixed Show resolved Hide resolved

luca-montaigut force-pushed the quoi-feur branch from 33abbff to 25b6092 Compare September 1, 2023 21:41

github-advanced-security bot found potential problems Sep 1, 2023

View reviewed changes

src/helpers/regex.helper.ts Fixed Show fixed Hide fixed

feat: improve quoi detection

97a90fd

luca-montaigut force-pushed the quoi-feur branch from 25b6092 to 97a90fd Compare September 1, 2023 21:50

luca-montaigut requested a review from potb September 2, 2023 11:58

potb reviewed Sep 3, 2023

View reviewed changes

src/quoi-feur.ts Outdated Show resolved Hide resolved

Merge branch 'master' into quoi-feur

62bd548

luca-montaigut force-pushed the quoi-feur branch 2 times, most recently from 08ae209 to d394298 Compare September 3, 2023 10:12

refactor: match new architecture

6b7d6b0

luca-montaigut force-pushed the quoi-feur branch from d394298 to 6b7d6b0 Compare September 3, 2023 14:23

luca-montaigut closed this Sep 4, 2023

luca-montaigut deleted the quoi-feur branch September 4, 2023 15:27

luca-montaigut mentioned this pull request Sep 4, 2023

feat: quoi feur #52

Merged

neolectron requested changes Sep 4, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add quoi-feur game with react #31

feat: add quoi-feur game with react #31

Uh oh!

luca-montaigut commented Aug 2, 2023 •

edited

Loading

Uh oh!

neolectron left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neolectron left a comment

Uh oh!

neolectron Sep 4, 2023

Uh oh!

neolectron Sep 4, 2023

Uh oh!

neolectron Sep 4, 2023

Uh oh!

neolectron Sep 4, 2023

Uh oh!

neolectron Sep 4, 2023

Uh oh!

Uh oh!

feat: add quoi-feur game with react #31

feat: add quoi-feur game with react #31

Uh oh!

Conversation

luca-montaigut commented Aug 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Feature quoi-feur :

Uh oh!

neolectron left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neolectron left a comment

Choose a reason for hiding this comment

Uh oh!

neolectron Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

neolectron Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

neolectron Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

neolectron Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

neolectron Sep 4, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

luca-montaigut commented Aug 2, 2023 •

edited

Loading