feat: replace twitter links with vxtwitter alternative #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoubqrt
suggested changes
May 20, 2023
| return; | ||
| } | ||
|
|
||
| const urls = message.content.match(/https?:\/\/\S+/g); |
There was a problem hiding this comment.
hi, can you please make a check if there is some twitter links in the message ? Because the bot will send a message on every message.
| 'https://vxtwitter.com' | ||
| ); | ||
|
|
||
| const newMessage = [`<@${message.author.id}>`, newContent].join('\n'); |
There was a problem hiding this comment.
I don't know if it's clear enough for the users to only mention the name of the user. It can be better to put Message de : @Ayoub or something else 🤷♂️
potb
added a commit
that referenced
this pull request
Jan 5, 2024
potb
added a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.