Skip to content

feat: manage recurring messages #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Conversation

luca-montaigut
Copy link
Contributor

Renamed branch for #45

Manage recurring messages with con job:
/recurrent +

  • add : recurring message daily / weekly / monthly
  • remove : recurring message
  • list : recurring message

@luca-montaigut luca-montaigut changed the title Feat/recurring message feat/recurring message Sep 4, 2023
@luca-montaigut luca-montaigut requested review from potb and neolectron and removed request for potb September 4, 2023 15:35
@luca-montaigut luca-montaigut changed the title feat/recurring message feat/recurring-message Sep 4, 2023
@luca-montaigut luca-montaigut changed the title feat/recurring-message feat: recurring message Sep 4, 2023
@neolectron
Copy link
Member

neolectron commented Sep 4, 2023

I think cron messages should be handled by the core instead of per-feature.
So we can manage where we store/restore them.
It would also remove the need for any other feature that needs cron to create a redis key, etc etc.
What do you think ?

@luca-montaigut
Copy link
Contributor Author

luca-montaigut commented Sep 4, 2023

I think cron messages should be handled by the core instead of per-feature. So we can manage where we store/restore them. It would also remove the need for any other feature that needs cron to create a redis key, etc etc. What do you think ?

I think it will be a good idea when we will have another feature that need cron. Same as the last refactoring, it was relevant because it really corresponds to our features and not to an hypothetical future.

We also have a topic regarding permissions on commands (ex: isModo)

(PS : I will apply change to this PR to match quoi-feur suggestions)

@luca-montaigut luca-montaigut requested a review from potb September 6, 2023 19:28
@potb potb changed the title feat: recurring message feat: manage recurring messages Sep 6, 2023
@luca-montaigut luca-montaigut merged commit 9b647eb into master Sep 6, 2023
@luca-montaigut luca-montaigut deleted the feat/recurring-message branch September 6, 2023 19:44
potb pushed a commit that referenced this pull request Jan 5, 2024
potb pushed a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants