fix: change removeEmoji regex to include custom emojis #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potb
reviewed
Sep 7, 2023
dilaouid
changed the title
dilaouid
changed the title
potb
pushed a commit
that referenced
this pull request
Jan 5, 2024
potb
pushed a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Just tried something after a bit of documentation)
I replaced the original regular expression to delete the emojis (
/(\p{Extended_Pictographic}|\p{Emoji_Component})/gu), since it doesn't catches the custom emojis which are formatted as such<:emoji_name:emoji_id>As shown in some requests, the custom emojis are really formatted as such:
