Skip to content

fix(quoi-feur): check if the trigger word is formatted in md #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 13, 2023

Conversation

dilaouid
Copy link
Contributor

@dilaouid dilaouid commented Sep 8, 2023

This member noticed that when 'quoi' is formatted in md, the bot ignores it:
image

Thought that MAYBE the bot should consider it. So the bot now remove all markdown.
As a result, the bot now removes all Markdown formatting. Fortunately, the md text is well-formatted, and it doesn't use unusual symbols like '<>' for emojis:

image

I also added a test to check it.

potb
potb previously approved these changes Sep 10, 2023
@dilaouid dilaouid reopened this Sep 11, 2023
@dilaouid dilaouid changed the title fix: check if the 'quoi' is formatted in md fix: check if the 'quoi' is formatted in md & also react in public threads of allowed channels Sep 11, 2023
@potb
Copy link
Contributor

potb commented Sep 11, 2023

Too many changes in here, a simple indicator is that the PR's name is too long and won't fit in a standard commit name

@dilaouid
Copy link
Contributor Author

Fixed the stupid commit

@dilaouid dilaouid changed the title fix: check if the 'quoi' is formatted in md & also react in public threads of allowed channels fix: check if the 'quoi' is formatted in md Sep 11, 2023
@ayoubqrt
Copy link
Contributor

@dilaouid you need to rebase and you need to run eslint autofix

@potb potb enabled auto-merge (squash) September 12, 2023 19:41
@potb potb changed the title fix: check if the 'quoi' is formatted in md fix(quoi-feur): check if the trigger word is formatted in md Sep 12, 2023
@potb potb disabled auto-merge September 12, 2023 19:43
@potb potb enabled auto-merge (squash) September 12, 2023 19:43
@potb potb merged commit 2a57c49 into codinglab-io:master Sep 13, 2023
potb added a commit that referenced this pull request Jan 5, 2024
potb added a commit that referenced this pull request Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants