-
Notifications
You must be signed in to change notification settings - Fork 13
fix(quoi-feur): check if the trigger word is formatted in md #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potb
previously approved these changes
Sep 10, 2023
Too many changes in here, a simple indicator is that the PR's name is too long and won't fit in a standard commit name |
Fixed the stupid commit |
@dilaouid you need to rebase and you need to run eslint autofix |
potb
reviewed
Sep 12, 2023
potb
approved these changes
Sep 12, 2023
luca-montaigut
approved these changes
Sep 13, 2023
potb
added a commit
that referenced
this pull request
Jan 5, 2024
Co-authored-by: Peïo Thibault <[email protected]>
potb
added a commit
that referenced
this pull request
Jan 5, 2024
Co-authored-by: Peïo Thibault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This member noticed that when 'quoi' is formatted in md, the bot ignores it:

Thought that MAYBE the bot should consider it. So the bot now remove all markdown.
As a result, the bot now removes all Markdown formatting. Fortunately, the md text is well-formatted, and it doesn't use unusual symbols like '<>' for emojis:
I also added a test to check it.