Skip to content

feat: make modules isolated using creation function #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Sep 17, 2023

Conversation

potb
Copy link
Contributor

@potb potb commented Sep 13, 2023

No description provided.

@potb potb self-assigned this Sep 13, 2023
@potb potb enabled auto-merge (squash) September 13, 2023 20:11
Copy link
Member

@neolectron neolectron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good changes overall, I will test this on next pass.

@potb potb requested a review from neolectron September 15, 2023 19:18
@neolectron neolectron self-requested a review September 16, 2023 06:19
Copy link
Member

@neolectron neolectron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@potb potb disabled auto-merge September 17, 2023 00:55
@potb potb merged commit b80a3d5 into master Sep 17, 2023
@potb potb deleted the feat/isolated_modules branch September 17, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants