Skip to content

ci: remove duplicated pipeline actions #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 13, 2023
Merged

ci: remove duplicated pipeline actions #83

merged 2 commits into from
Sep 13, 2023

Conversation

neolectron
Copy link
Member

No description provided.

@neolectron neolectron requested a review from potb September 13, 2023 21:40
potb
potb reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@potb potb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to keep the docker build because some changes may make the build fafil

@neolectron
Copy link
Member Author

neolectron commented Sep 13, 2023 •
edited
Loading

But we're already building without docker in the PR.
Should I add docker anyway ?
If so, should I remove the regular build ?

@potb
Copy link
Contributor

potb commented Sep 13, 2023

Yeah but, let's say you change something in the dependencies, we won't catch the fail in the CI because it's not isolated

@neolectron neolectron enabled auto-merge (squash) September 13, 2023 22:10
@neolectron neolectron merged commit 26c3cb3 into master Sep 13, 2023
@neolectron neolectron deleted the fix/pipeline-run-once branch September 13, 2023 22:29
potb pushed a commit that referenced this pull request Jan 5, 2024
@neolectron @potb
ci: remove duplicated pipeline actions (#83)
049cf46
potb pushed a commit that referenced this pull request Jan 5, 2024
@neolectron @potb
ci: remove duplicated pipeline actions (#83)
2a29a5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potb potb potb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neolectron @potb