Skip to content

Allow Array.prototype Augmenting #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2012
Merged

Allow Array.prototype Augmenting #16

merged 1 commit into from
Jun 24, 2012

Conversation

mkantor
Copy link
Contributor

@mkantor mkantor commented Jun 24, 2012

This plugin had problems when Array.prototype was augmented (something done by many JavaScript shims, e.g. es5-shim and Augment.js).

My solution was to use $.each instead of for...in iteration in several places, which is smarter about avoiding properties from array prototypes.

Here's a quick test:

I also bumped the version number to 2.5.

codler added a commit that referenced this pull request Jun 24, 2012
Allow Array.prototype Augmenting
@codler codler merged commit 1dd681d into codler:master Jun 24, 2012
@codler
Copy link
Owner

codler commented Jun 24, 2012

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants