Updated required version of property-access #10
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if we should increase dependency version or just remove this method, what do you think @defrag ? |
|
I would vote for removing the method and sticking with 2.3. |
|
Agree, @pskt coud you please bring back version 2.3 and remove this method call? Thanks! |
|
Thanks @pskt , nice catch 🍻 |
|
Fixed, thanks for pointing that out @pskt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Library is using method
Symfony\Component\PropertyAccess\PropertyAccessorBuilder::enableExceptionOnInvalidIndex()which is unavailable in symfony/property-access 2.3http://api.symfony.com/2.3/Symfony/Component/PropertyAccess/PropertyAccessorBuilder.html
So I bumped reqiored version of this component to 2.4