Skip to content

Matcher fails when trying to use empty string as a pattern #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2018
Merged

Matcher fails when trying to use empty string as a pattern #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Parser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ public function parse(string $pattern) : Pattern\TypePattern

public function getAST(string $pattern) : AST\Pattern
{
if($pattern === '') {
return new AST\Pattern(new AST\Type(''));
}

$this->lexer->setInput($pattern);
return $this->getPattern();
}
Expand Down
28 changes: 28 additions & 0 deletions tests/MatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,4 +421,32 @@ public static function nullExamples()
],
];
}

public static function emptyPatternString()
{
return [
[
'', '', true,
'123', '', false,
' ', '', false,
null, '', false,
1, '', false,
0, '', false,
'{"name": "123"}', '{"name": ""}', false,
'{"name": ""}', '{"name": ""}', true,
],
];
}

/**
* @dataProvider emptyPatternString
*/
public function test_empty_pattern_in_the_json($value, $pattern, $expectedResult)
{
$factory = new SimpleFactory();
$matcher = $factory->createMatcher();

$match = $matcher->match($value, $pattern);
$this->assertSame($expectedResult, $match);
}
}