Skip to content

Fixed unbouded array to work with objects & iterateMatch matehod refactoring #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2014
Merged

Fixed unbouded array to work with objects & iterateMatch matehod refactoring #20

merged 1 commit into from
Jun 22, 2014

Conversation

norberttech
Copy link
Member

Unbounded array pattern added by @K-Phoen was not working with arrays built from objects.
Failing example:

    array(
        '[{"name": "Norbert"},{"name":"Michał"},{"name":"Bob"},{"name":"Martin"}]', // value
        '[{"name": "Norbert"},@...@]' // pattern
    ),

This PR fix this small issue and simplify iterateMatch method in ArrayMatcher.

@norberttech
Copy link
Member Author

ping @defrag

defrag added a commit that referenced this pull request Jun 22, 2014
@defrag
Merge pull request #20 from norzechowicz/unbounded_array
58a6348 
Fixed unbouded array to work with objects & iterateMatch matehod refactoring
@defrag defrag merged commit 58a6348 into coduo:master Jun 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@norberttech @defrag