Skip to content

include ArrayMatcher in OrMatcher to fix issues with @null@||@array@ #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2020

Conversation

mtomala
Copy link
Contributor

@mtomala mtomala commented Oct 9, 2020

fixes #212

@norberttech
Copy link
Member

Thanks @mtomala this looks good!
I will release it as a 5.0.1, could you please also confirm that this bug exists at branch 4.0 so I can merge it additionally to this branch and release 4.0.2?

@mtomala
Copy link
Contributor Author

mtomala commented Oct 9, 2020

@norberttech Hi. I confirm that this bug also exists at branch 4.0. I've prepared additional pull request for this: #214

@norberttech norberttech merged commit 2e8ed68 into coduo:5.x Oct 9, 2020
norberttech pushed a commit that referenced this pull request Oct 9, 2020
#213)

* include ArrayMatcher in OrMatcher to fix issues with `@null@||@array@` pattern

* more test cases

Co-authored-by: michal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to match @null@||@array@
2 participants