Skip to content

CallbackMatcher should not be executed for internal function names #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2015
Merged

CallbackMatcher should not be executed for internal function names #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Coduo/PHPMatcher/Matcher/CallbackMatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ public function match($value, $pattern)
*/
public function canMatch($pattern)
{
return is_callable($pattern);
return is_object($pattern) && is_callable($pattern);
}
}
1 change: 1 addition & 0 deletions tests/Coduo/PHPMatcher/Matcher/CallbackMatcherTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ function test_negative_can_match()
{
$matcher = new CallbackMatcher();
$this->assertFalse($matcher->canMatch(new \DateTime()));
$this->assertFalse($matcher->canMatch('SIN'));
}

function test_positive_matches()
Expand Down