Skip to content

Upgrade to Scala 3.0.0-RC1 #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Upgrade to Scala 3.0.0-RC1 #44

wants to merge 1 commit into from

Conversation

jodersky
Copy link
Member

@jodersky jodersky commented Mar 6, 2021 •
edited
Loading

Pending resolution of scala/scala3#11628 and scala/scala3#11630

@jodersky jodersky force-pushed the jo/scala-3.0.0-RC1 branch from 92f5eac to 3bf1ff9 Compare March 6, 2021 12:13
@jodersky
Copy link
Member Author

jodersky commented Mar 6, 2021

FYI, I tested this on my machine with a custom version of dotty with fixes applied to the issue, and all examples work!

@jodersky jodersky marked this pull request as ready for review March 6, 2021 16:28
@jodersky jodersky force-pushed the jo/scala-3.0.0-RC1 branch from 3bf1ff9 to 5415c8c Compare March 6, 2021 16:32
@jodersky
Copy link
Member Author

jodersky commented Mar 8, 2021 •
edited
Loading

I was able to add a workaround for scala/scala3#11630, but unfortunately it looks like this PR will be blocked until a fix for scala/scala3#11628 is released in RC2.

I also know the workaround for 11630 is kind of ugly, but I'm also working on adding cask to Dotty's community build and it seems like it's the quickest option to move forward. @lihaoyi, would you be ok with me adding cask to the community-build with this workaround?

@jodersky jodersky force-pushed the jo/scala-3.0.0-RC1 branch 2 times, most recently from 842f3ce to a80b6c6 Compare March 8, 2021 15:01
@jodersky jodersky force-pushed the jo/scala-3.0.0-RC1 branch from a80b6c6 to 742ea27 Compare March 8, 2021 15:12
@jodersky jodersky mentioned this pull request Mar 8, 2021
Closed
@jodersky jodersky force-pushed the jo/scala-3.0.0-RC1 branch from 742ea27 to 6e6922c Compare March 9, 2021 18:06
@jodersky
Copy link
Member Author

jodersky commented Mar 9, 2021

The workaround is no longer necessary in latest dotty master. I removed it here.

@jodersky jodersky added the blocked Blocked by something external label Mar 9, 2021
@jodersky
Copy link
Member Author

Cask is in the dotty community build now! We'll wait until the next RC release before publishing cask to maven central

@jodersky jodersky removed the blocked Blocked by something external label Apr 1, 2021
@jodersky
Copy link
Member Author

jodersky commented Apr 1, 2021

This has been merged. As of version 0.7.9, cask is now available for Scala 3.0.0-RC2

@jodersky jodersky closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jodersky