chore(ci): add testing on Java 17 and dependabot #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Valid failure on 17 I need to check out. |
ckipp01
commented
Jul 2, 2022
|
|
||
| val res3 = requests.post( | ||
| "https://httpbin.org/post", | ||
| compress = requests.Compress.Deflate, | ||
| data = new RequestBlob.ByteSourceRequestBlob("Hear me moo") | ||
| ) | ||
| assert(read(new String(res2.bytes))("data").toString == | ||
| """"data:application/octet-stream;base64,H4sIAAAAAAAAAPNUSMxVSM4vBwCAGeD4CAAAAA=="""") | ||
| assert(read(new String(res3.bytes))("data").toString == |
There was a problem hiding this comment.
I believe this was supposed to be res3, not res2 or else we're never doing anything with res3.
| @@ -191,16 +191,15 @@ object RequestTests extends TestSuite{ | |||
| compress = requests.Compress.Gzip, | |||
| data = new RequestBlob.ByteSourceRequestBlob("I am cow") | |||
| ) | |||
| assert(read(new String(res2.bytes))("data").toString == | |||
| """"data:application/octet-stream;base64,H4sIAAAAAAAAAPNUSMxVSM4vBwCAGeD4CAAAAA=="""") | |||
| assert(read(new String(res2.bytes))("data").toString.contains("data:application/octet-stream;base64,H4sIAAAAAA")) | |||
There was a problem hiding this comment.
This is interesting. So this was changed in #108 from a contains like I have here to an exact match. However, I notice a difference between Java 8 and 17 here. With 8 you'll get
// "data:application/octet-stream;base64,H4sIAAAAAAAAAPNUSMxVSM4vBwCAGeD4CAAAAA=="
but with 17 you'll get
// "data:application/octet-stream;base64,H4sIAAAAAAAA//NUSMxVSM4vBwCAGeD4CAAAAA=="
I'm not exactly sure why, but is this potentially why it used to be a contains instead of an exact match to account for this? Is there something different with gzip between 8 and 17 here, and that's also why it doesn't change for the Deflate example down below?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.