JoinNullable deserialisation fix #70
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, JoinNullable in order to determine that R shouldBe Option or Some is deserialising whole set and then counting nulls. In cases where you have user written TypeMapper, that doesn't do nulls tricks(like inside Dialects.scala), such:
then leftJoin query, where the right side can be nullable instead of returning (A, None) will fail with exception, check new test in DataTypesTests
new implementation will check first if the rest of columns are null without deserialising them into type and only if one of them is not - will try to construct
comments on everything are welcome!
fixes #65