Skip to content
This repository was archived by the owner on Mar 23, 2021. It is now read-only.
This repository was archived by the owner on Mar 23, 2021. It is now read-only.

Simplify build script/process #268

Closed
@thomaseizinger

Description

@thomaseizinger

Problem

Currently, we have 2 feature flags and several conditional code paths to support windows or unix, depending on which platform we want to build for. This is because cargo does not support compiling a dependency with different features based on the target platform..

Goal

No feature-flags in our build process for support multiple platforms. cargo build should work on each platform (Linux, Windows, MacOS) and produce a binary that works.

Recommendation

I believe we might be able to fix some thing things downstream in the shiplift crate that would allow us to "just" depend on shiplfit and shiplift it self compiles according to the target platform without and special feature flags.

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions