Skip to content

Remove base-orphans' test suite from skipped-tests #4850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Remove base-orphans' test suite from skipped-tests #4850

merged 1 commit into from
Sep 27, 2019

Conversation

RyanGlScott
Copy link
Contributor

base-orphans was mysteriously listed in the skipped-tests
category due to cyclic dependencies. Despite this, I am unable to
observe the supposed cyclic dependencies when I build it locally.
As a result, I'm going to optimistically remove it from this
category.

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    stack unpack $package-$version  # $version is optional
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    

`base-orphans` was mysteriously listed in the `skipped-tests`
category due to cyclic dependencies. Despite this, I am unable to
observe the supposed cyclic dependencies when I build it locally.
As a result, I'm going to optimistically remove it from this
category.
@DanBurton DanBurton merged commit 1364e63 into commercialhaskell:master Sep 27, 2019
@DanBurton
Copy link
Contributor

This is due to (what I consider to be) a bug in stack. I think now that the build machine has built hspec, we can go ahead and try enabling this test suite again.

@DanBurton
Copy link
Contributor

Unfortunately I'm still seeing this error on the build server:

In the dependencies for base-orphans-0.8.1:
    hspec dependency cycle detected: hspec, base-orphans, primitive, tf-random, hspec-core, hspec,
          half, OpenGLRaw, GLURaw, OpenGL, OpenAL, ALUT
needed since base-orphans is a build target.

Some different approaches to resolving this:


Plan construction failed.

I don't quite understand it, but this is related to how the stackage build process uses stack.

The related stack bug: commercialhaskell/stack#2583

I'm going to revert this for now. Not sure exactly what the path to resolution is.

@RyanGlScott
Copy link
Contributor Author

Thanks for the pointer to commercialhaskell/stack#2583! I suppose that explains why I didn't observe this failure locally—it only seems to occur in multi-project configurations. I'll be more careful when trying to remove things under Cyclic dependencies in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants