Log githook output

[kentcdodds]

I have a pre-commit hook that runs eslint. I don't see any output from eslint when that is running when using commitizen. Any idea why that is?

[kentcdodds]

Sorry, to be more specific, I see the output when the hook has finished and the commit has succeeded, but I don't see any of the output while it's in progress (like I do when I commit normally).

[jimthedev]

Hi Kent. Sorry it took me a bit to get back to you. Can you provide your pre-commit hook? In my case, I actually don't see any eslint output when I run git cz regardless of whether it succeeds or fails. Instead am greeted with a generic, relatively unhelpful error (✗ Commit failed. Did you forget to 'git add' your files?) or with a generic success message (✓ Commit succeeded). The only scenario that running git cz will output your eslint info right now is if you have not configured commitizen in package in the current working directory. This is because by default, when commitizen is called but the current working directory repo does not have an adapter set in package.json/.czrc/.cz.js then it should completely remove itself from the scenario and revert to the normal git commit behavior.

Currently the 'user-friendly' :D default is that commitizen will try to commit, wait for the return code and then present a pretty message to the user based on the return code. This means that we're not piping the output of the command in real time. We probably could explore that scenario either by default or first behind a flag.

Again, if you have a scenario where you have a properly configured adapter in a repo and are getting actual eslint output back, I'd love to see it the pre-commit hook. Perhaps mine could be tweaked.

[kentcdodds]

Try out the angular-formly repo.

• Kent C. Dodds

(Sent from my mobile device, please forgive typos or brevity)
On Aug 29, 2015 7:55 PM, "Jim Cummins" notifications@github.com wrote:

Hi Kent. Sorry it took me a bit to get back to you. Can you provide your
pre-commit hook? In my case, I actually don't see any eslint output when I
run git cz regardless of whether it succeeds or fails. Instead am greeted
with a generic, relatively unhelpful error (✗ Commit failed. Did you forget
to 'git add' your files?) or with a generic success message (✓ Commit
succeeded). The only scenario that running git cz will output your eslint
info right now is if you have not configured commitizen in package in the
current working directory. This is because by default, when commitizen is
called but the current working directory repo does not have an adapter set
in package.json/.czrc/.cz.js then it should completely remove itself from
the scenario and revert to the normal git commit behavior.

Currently the 'user-friendly' :D default is that commitizen will try to
commit, wait for the return code and then present a pretty message to the
user based on the return code. This means that we're not piping the output
of the command in real time. We probably could explore that scenario either
by default or first behind a flag.

Again, if you have a scenario where you have a properly configured adapter
in a repo and are getting actual eslint output back, I'd love to see it the
pre-commit hook. Perhaps mine could be tweaked.

—
Reply to this email directly or view it on GitHub
#8 (comment).

[kentcdodds]

Sorry, I misunderstood. I don't have a scenario where things are working
properly... Would love it though.

• Kent C. Dodds

(Sent from my mobile device, please forgive typos or brevity)
On Aug 29, 2015 7:57 PM, "Kent C. Dodds" kent@doddsfamily.us wrote:

Try out the angular-formly repo.

• Kent C. Dodds

(Sent from my mobile device, please forgive typos or brevity)
On Aug 29, 2015 7:55 PM, "Jim Cummins" notifications@github.com wrote:

Hi Kent. Sorry it took me a bit to get back to you. Can you provide your
pre-commit hook? In my case, I actually don't see any eslint output when I
run git cz regardless of whether it succeeds or fails. Instead am
greeted with a generic, relatively unhelpful error (✗ Commit failed. Did
you forget to 'git add' your files?) or with a generic success message (✓
Commit succeeded). The only scenario that running git cz will output your
eslint info right now is if you have not configured commitizen in package
in the current working directory. This is because by default, when
commitizen is called but the current working directory repo does not have
an adapter set in package.json/.czrc/.cz.js then it should completely
remove itself from the scenario and revert to the normal git commit
behavior.

Currently the 'user-friendly' :D default is that commitizen will try to
commit, wait for the return code and then present a pretty message to the
user based on the return code. This means that we're not piping the output
of the command in real time. We probably could explore that scenario either
by default or first behind a flag.

Again, if you have a scenario where you have a properly configured
adapter in a repo and are getting actual eslint output back, I'd love to
see it the pre-commit hook. Perhaps mine could be tweaked.

—
Reply to this email directly or view it on GitHub
#8 (comment).

[jimthedev]

I am no longer using the pretty commit messages. Instead cz should output the raw git results. This should help with this although I'll probably have you double check it on release.

[kentcdodds]

👍

[jimthedev]

Ok, 2.0.2 seems to be the most stable release in the past 24 hours so we can probably check this with it. I can try it out but it might not be until tomomorrow.

[kentcdodds]

You'll notice that it worked :-)