Skip to content

fix: harden adapter callback error handling #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 6, 2016
Merged

fix: harden adapter callback error handling #314

merged 1 commit into from
Aug 6, 2016

Conversation

marionebl
Copy link
Contributor

  • minor code cleanups (cli/strategies/git-cz.js)
  • pass error as first argument into dispatchGitCommit callback
  • handle errors raised by commitizen adapters via optional error argument
  • attach stderr to error message in case of git commit errors

Fix #308

@marionebl
fix: harden adapter callback error handling
34c5327 
*  minor code cleanups (cli/strategies/git-cz.js)
*  pass error as first argument into `dispatchGitCommit` callback
*  handle errors raised by commitizen adapters via optional error argument
*  attach stderr to error message in case of `git commit` errors

Fix commitizen#308
@LinusU
Copy link
Contributor

LinusU commented Aug 5, 2016

Great, thanks for the quick response!

@LinusU
Copy link
Contributor

LinusU commented Aug 5, 2016

(waiting on appveyor to turn green)

@LinusU LinusU merged commit 1d4b96e into commitizen:master Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marionebl @LinusU