Skip to content

Use only file names when determining if the staging area is clean #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2015

Conversation

d4rkr00t
Copy link
Contributor

When there is a huge diff we got an error related to reach of maximum stack size. As a way of fix
this issue I suggest to use only names of staged files instead of whole diff.

Is it ok?

… clean

When there is a huge diff we got an error related to reach of maximum stack size. As a way of fix
this issue i suggest to use only names of staged files instead of whole diff.
jimthedev added a commit that referenced this pull request Oct 22, 2015
Use only file names when determining if the staging area is clean
@jimthedev jimthedev merged commit 29ffe64 into commitizen:master Oct 22, 2015
@jimthedev
Copy link
Member

Great idea. Much obliged for the PR. 😊

@jimthedev
Copy link
Member

Released in 2.2.1

@d4rkr00t
Copy link
Contributor Author

Wow, so fast 😄! Thanks!

@jimthedev
Copy link
Member

No problem! @kentcdodds tutorials make quick releases a breeze:
https://egghead.io/series/how-to-write-an-open-source-javascript-library
On Thu, Oct 22, 2015 at 7:46 AM Stanislav Sysoev [email protected]
wrote:

Wow, so fast [image: 😄]! Thanks!


Reply to this email directly or view it on GitHub
#37 (comment).

@d4rkr00t
Copy link
Contributor Author

Yep, I saw this, thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants