-
-
Notifications
You must be signed in to change notification settings - Fork 232
check for valid version of node / nodejs #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
if im not wrong, this would require making changes to after successful node detection, we need to check the version and if it's below the threshold, raise a runtime exception and exit the program. probably output a logging message before doing that. |
@manu-chroma A good plan, yep! |
any threshold version to check against? currently setting it to |
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
The spec currently sets the minimum at ECMAScript 5.1, which seems to be well supported by Node.js 0.10.25. This is the version that ships in Ubuntu 14.04. Debian 8 ships with Node.js 0.10.29. There's lots of goodies in ECMAScript 6+, but according to http://node.green/ you want to be using Node.js 6.0 or later to have good compliance with the standards. We can consider bumping the requirement to ECMAScript 6 in the v1.1 spec. |
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
for the time being, what would you suggest should go in should we stick to the current specification or set the minimum threshold version to Node.js 6.4.0 ? relevant PR: #337 |
@manu-chroma The minimum version to detect should be |
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
sticking to |
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
8d0fe99 Merge pull request common-workflow-language#254 from common-workflow-language/real-1.0 25a5565 Rename v1.0.dev4 to v1.0 f7617cc Add v1.0 as real valid version. 185953c Merge pull request common-workflow-language#253 from common-workflow-language/spec-cleanup f9f2209 Simplify CommandLineTool d0e774b simplify Process a34a36e Merge pull request common-workflow-language#252 from common-workflow-language/description2doc git-subtree-dir: cwltool/schemas git-subtree-split: 8d0fe99
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
- raises runtime exception if install node version is below a threshold version. - Fixes common-workflow-language#254
for example, v0.10.25 is too old
https://www.biostars.org/p/226909/#226917
The text was updated successfully, but these errors were encountered: