Skip to content

Behaviour when both workflow's step and its tool define a default value for an input #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
undu opened this issue Aug 21, 2017 · 3 comments

Comments

@undu
Copy link
Contributor

undu commented Aug 21, 2017

In the case where both a workflow defines a default value and the tool in the step also defines one, cwltool picks the default value in the tool.

I haven't seen this behaviour been defined anywhere, and I would expect the values in the tool to be overridden since this is the only way I've seen to 'hardcode' values in workflows, but I don't know if that makes sense for everybody.

For example:
workflow.cwl

[...]
steps:
  step:
    run: tool.cwl
    in:
      parameter:
        default: 'workflow'
[...]
[...]
baseCommand: echo
inputs:
  parameter:
    type: string
    default: tool

This would print tool, I'd expect it to print workflow.

Is this something expected? I can produce conformity tests and tests for cwltool if necessary.

@esanzgar
Copy link

I don't see this issue in version 1.0.20170928192020 of the cwtool

@undu
Copy link
Contributor Author

undu commented Nov 6, 2017

I see this behaviour with cwltool==1.0.20171017195544.
Hopefully I can get around producing some reproducibility tests.

@tetron
Copy link
Member

tetron commented Jan 11, 2018

Should be fixed now.

@tetron tetron closed this as completed Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants