-
-
Notifications
You must be signed in to change notification settings - Fork 231
Add helpful error message when a program is terminated by a (Unix) signal, such as a segfault #1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Log a warning message if a job fails. A negative return code indicates that the job was terminated by a signal.
Reformatted the warning message in line with other job-related log messages.
Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make format
should clean up the linting issue
You can also run tox
locally to duplicate what the CI does
Codecov Report
@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
- Coverage 66.08% 66.08% -0.01%
==========================================
Files 91 91
Lines 16299 16309 +10
Branches 4222 4226 +4
==========================================
+ Hits 10772 10778 +6
- Misses 4379 4383 +4
Partials 1148 1148
Continue to review full report at Codecov.
|
Reformatted the code by running `make format`.
Done and pushed new commit. |
I'm confused by the message from codecov[bot]. How can this small addition cause a drop in coverage of 16.16% and affect over 60 files 😕 |
It is because the first CI run failed. That comment will update as the CI completes |
Congratulations! I'm surprised, though. I didn't know we had a test that is terminated by a POSIX signal |
Fixes #580