Skip to content

Add helpful error message when a program is terminated by a (Unix) signal, such as a segfault #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2021

Conversation

gmloose
Copy link
Contributor

@gmloose gmloose commented Nov 24, 2021

Fixes #580

Log a warning message if a job fails. A negative return code indicates
that the job was terminated by a signal.
Reformatted the warning message in line with other job-related log messages.
@mr-c
Copy link
Member

mr-c commented Nov 24, 2021

Thanks!

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make format should clean up the linting issue

You can also run tox locally to duplicate what the CI does

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1569 (b4efd8f) into main (352daf6) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1569      +/-   ##
==========================================
- Coverage   66.08%   66.08%   -0.01%     
==========================================
  Files          91       91              
  Lines       16299    16309      +10     
  Branches     4222     4226       +4     
==========================================
+ Hits        10772    10778       +6     
- Misses       4379     4383       +4     
  Partials     1148     1148              
Impacted Files Coverage Δ
cwltool/job.py 77.15% <100.00%> (+0.23%) ⬆️
job.py 62.04% <0.00%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352daf6...b4efd8f. Read the comment docs.

Reformatted the code by running `make format`.
@gmloose
Copy link
Contributor Author

gmloose commented Nov 24, 2021

make format should clean up the linting issue

Done and pushed new commit.

@gmloose
Copy link
Contributor Author

gmloose commented Nov 24, 2021

I'm confused by the message from codecov[bot]. How can this small addition cause a drop in coverage of 16.16% and affect over 60 files 😕

@mr-c
Copy link
Member

mr-c commented Nov 24, 2021

I'm confused by the message from codecov[bot]. How can this small addition cause a drop in coverage of 16.16% and affect over 60 files 😕

It is because the first CI run failed. That comment will update as the CI completes

@mr-c
Copy link
Member

mr-c commented Nov 24, 2021

The diff coverage is 100.00%.

Congratulations! I'm surprised, though. I didn't know we had a test that is terminated by a POSIX signal

@mr-c mr-c merged commit e6a1e1f into common-workflow-language:main Nov 24, 2021
@gmloose gmloose deleted the issue-580 branch November 24, 2021 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helpful error message when a program is terminated by a (Unix) signal, such as a segfault
2 participants