Skip to content

Correct usage of tmpdir and tmp_outdir prefixes #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

alexbarrera
Copy link
Contributor

Currently these arguments only work correctly when using Docker.
This patch avoid execution halt when the arguments are provided
and the --no-container flag is used.

Currently these arguments only work correctly when using Docker.
This patch avoid execution halt when the arguments are provided
 and the `--no-container` flag is used.

# Conflicts:
#	cwltool/process.py
@tetron
Copy link
Member

tetron commented Aug 20, 2016

Is this related to #60 ?

@alexbarrera
Copy link
Contributor Author

Yes, is an updated PR regarding the same issue, using tmp dirs without the --no-container flag

@cwl-bot
Copy link

cwl-bot commented Nov 15, 2016

Can one of the admins verify this patch?

@tetron
Copy link
Member

tetron commented Dec 6, 2016

The bug is partially fixed by #244, unfortunately I overlooked this PR when making that fix.

This has tests and fixes a couple additional things, so I'm going to keep it open with the intent to merge it.

@alexbarrera are you willing/able to fix the merge conflicts to bring this PR up to date?

@tetron tetron mentioned this pull request Dec 6, 2016
@alexbarrera
Copy link
Contributor Author

@tetron I'd be willing to work on this, but it will take me a few days to catch up with the current state of cwltool.

inutano added a commit to inutano/cwltool that referenced this pull request Jun 8, 2017
@inutano
Copy link

inutano commented Jun 9, 2017

Hi @alexbarrera, are you still willing to resolve conflicts on this? Otherwise, I'd like to send another pull request just to make changes in cwltool/process.py so that cwltool can use --tmp-dir-prefix/--tmp-outdir-prefix with --no-container option. cc. @tetron

@alexbarrera
Copy link
Contributor Author

Hi @inutano. I have failed to find the appropriate time to catch up with the latest state of cwltool, so please feel free to implement your own solution. Thanks for the heads up.

@inutano
Copy link

inutano commented Jun 9, 2017

@alexbarrera OK, I'll do it. Thanks!

@tetron
Copy link
Member

tetron commented Oct 1, 2018

This is out of date and appears to be superceded by a PR from @inutano

@tetron tetron closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants