-
-
Notifications
You must be signed in to change notification settings - Fork 232
Correct usage of tmpdir and tmp_outdir prefixes #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct usage of tmpdir and tmp_outdir prefixes #167
Conversation
Currently these arguments only work correctly when using Docker. This patch avoid execution halt when the arguments are provided and the `--no-container` flag is used. # Conflicts: # cwltool/process.py
Is this related to #60 ? |
Yes, is an updated PR regarding the same issue, using tmp dirs without the |
Can one of the admins verify this patch? |
The bug is partially fixed by #244, unfortunately I overlooked this PR when making that fix. This has tests and fixes a couple additional things, so I'm going to keep it open with the intent to merge it. @alexbarrera are you willing/able to fix the merge conflicts to bring this PR up to date? |
@tetron I'd be willing to work on this, but it will take me a few days to catch up with the current state of cwltool. |
Hi @alexbarrera, are you still willing to resolve conflicts on this? Otherwise, I'd like to send another pull request just to make changes in cwltool/process.py so that cwltool can use --tmp-dir-prefix/--tmp-outdir-prefix with |
Hi @inutano. I have failed to find the appropriate time to catch up with the latest state of cwltool, so please feel free to implement your own solution. Thanks for the heads up. |
@alexbarrera OK, I'll do it. Thanks! |
This is out of date and appears to be superceded by a PR from @inutano |
Currently these arguments only work correctly when using Docker.
This patch avoid execution halt when the arguments are provided
and the
--no-container
flag is used.