Skip to content

CONTRIBUTING.md: recommend updating pip in the dev venv #1726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

simleo
Copy link
Contributor

@simleo simleo commented Aug 30, 2022

I tried the "traditional workflow" described in CONTRIBUTING.md but got the following error:

ERROR: Double requirement given: ruamel.yaml<0.17.22,>=0.16.0 (from -r mypy-requirements.txt (line 2)) (already in ruamel.yaml<0.17.22,>=0.15 (from -r requirements.txt (line 3)), name='ruamel.yaml')

That was with pip 20.0.2. I solved by updating pip to the latest version, hence this PR.

Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1726 (6d9b9c3) into main (6f29c59) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
+ Coverage   66.56%   66.60%   +0.03%     
==========================================
  Files          89       89              
  Lines       15846    15846              
  Branches     4188     4188              
==========================================
+ Hits        10548    10554       +6     
+ Misses       4207     4203       -4     
+ Partials     1091     1089       -2     
Impacted Files Coverage Δ
cwltool/cwltool/singularity.py 51.94% <0.00%> (+0.43%) ⬆️
cwltool/cwltool/job.py 62.45% <0.00%> (+0.98%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kinow kinow enabled auto-merge (rebase) August 30, 2022 11:29
@kinow kinow merged commit 0771b99 into common-workflow-language:main Aug 30, 2022
@simleo simleo deleted the update_contrib branch August 30, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants