Skip to content

support podman even when not installed as "docker" alias #1769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Dec 1, 2022

@mr-c mr-c marked this pull request as ready for review December 1, 2022 11:51
@codecov
Copy link

codecov bot commented Dec 1, 2022

Codecov Report

Merging #1769 (7612a6e) into main (0099f11) will increase coverage by 0.02%.
The diff coverage is 85.00%.

@@            Coverage Diff             @@
##             main    #1769      +/-   ##
==========================================
+ Coverage   82.45%   82.48%   +0.02%     
==========================================
  Files          47       47              
  Lines        8181     8195      +14     
  Branches     2232     2235       +3     
==========================================
+ Hits         6746     6760      +14     
  Misses        941      941              
  Partials      494      494              
Impacted Files Coverage Δ
cwltool/job.py 81.21% <57.14%> (+0.14%) ⬆️
cwltool/docker.py 72.13% <75.00%> (+0.46%) ⬆️
cwltool/builder.py 90.88% <100.00%> (ø)
cwltool/command_line_tool.py 86.95% <100.00%> (+0.03%) ⬆️
cwltool/context.py 97.05% <100.00%> (ø)
cwltool/cwlrdf.py 29.06% <100.00%> (ø)
cwltool/load_tool.py 86.66% <100.00%> (ø)
cwltool/main.py 75.59% <100.00%> (+0.12%) ⬆️
cwltool/pack.py 88.00% <100.00%> (ø)
cwltool/process.py 92.47% <100.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2022

This pull request introduces 1 alert when merging d47f15c into 0099f11 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@cwl-bot
Copy link

cwl-bot commented Dec 1, 2022

This pull request has been mentioned on Common Workflow Language Discourse. There might be relevant details there:

https://cwl.discourse.group/t/cannot-get-cwltool-to-run-with-podman-when-step-has-dockerrequirement/711/7

@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2022

This pull request introduces 1 alert when merging 28fa2d2 into 0099f11 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@mr-c mr-c force-pushed the podman_no_docker_alias branch from 28fa2d2 to 7612a6e Compare December 1, 2022 12:35
@lgtm-com
Copy link

lgtm-com bot commented Dec 1, 2022

This pull request introduces 1 alert when merging 7612a6e into 0099f11 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@mr-c mr-c merged commit 60f0dac into main Dec 1, 2022
@mr-c mr-c deleted the podman_no_docker_alias branch December 1, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants