Skip to content

Move sys.exit #1772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Move sys.exit #1772

merged 2 commits into from
Dec 4, 2022

Conversation

jfennick
Copy link
Contributor

@jfennick jfennick commented Dec 3, 2022

This PR simply moves the sys.exit() call so that users call call run() without exiting. I'm currently copy & pasting the body of run (without the sys.exit call of course), but that isn't ideal.

FYI the reason I'm interested in calling run() is because the normal way of using the cwltool Python API does not (easily) allow using all of the CLI arguments. (In particular, --cachedir and --provenance)

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Merging #1772 (dcf5bb2) into main (60f0dac) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1772      +/-   ##
==========================================
+ Coverage   82.47%   82.49%   +0.01%     
==========================================
  Files          47       47              
  Lines        8195     8197       +2     
  Branches     2235     2235              
==========================================
+ Hits         6759     6762       +3     
  Misses        941      941              
+ Partials      495      494       -1     
Impacted Files Coverage Δ
cwltool/main.py 75.65% <100.00%> (+0.06%) ⬆️
cwltool/singularity.py 65.80% <0.00%> (+0.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2022

This pull request introduces 1 alert when merging bd2dced into 60f0dac - view on LGTM.com

new alerts:

  • 1 for Except block handles 'BaseException'

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@lgtm-com
Copy link

lgtm-com bot commented Dec 3, 2022

This pull request introduces 1 alert when merging dcf5bb2 into 60f0dac - view on LGTM.com

new alerts:

  • 1 for Variable defined multiple times

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@mr-c mr-c merged commit 38f42e6 into common-workflow-language:main Dec 4, 2022
@mr-c
Copy link
Member

mr-c commented Dec 4, 2022

Thank you @jfennick ; I see that you are the main author of https://github.com/jfennick/workflow_inference_compiler ; will you be submitting a talk to the 2023 CWL Conference about that tool? I'd love to see it!

https://cwl.discourse.group/t/deadline-for-talk-proposals-is-monday-january-16th-2023/720

@jfennick
Copy link
Contributor Author

jfennick commented Dec 8, 2022

Glad you like it! FYI development is now moved to https://github.com/PolusAI/workflow-inference-compiler

Pending paperworks and approvals from my management (likely), then yeah I'll be happy to give a talk.

@jfennick jfennick deleted the no_sys_exit branch March 9, 2023 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants