Skip to content

required outputs with secondaryFiles fix for containers #1870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2023

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jul 1, 2023

Fixes #1869

@mr-c mr-c marked this pull request as ready for review July 1, 2023 01:55
@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Merging #1870 (9234c03) into main (263a554) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1870      +/-   ##
==========================================
+ Coverage   83.85%   83.87%   +0.02%     
==========================================
  Files          46       46              
  Lines        8156     8157       +1     
  Branches     2224     2224              
==========================================
+ Hits         6839     6842       +3     
+ Misses        845      843       -2     
  Partials      472      472              
Impacted Files Coverage Δ
cwltool/command_line_tool.py 87.31% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@mr-c mr-c force-pushed the output_secfile_required_from_container branch from d82e8d7 to de3736c Compare July 1, 2023 02:00
@mr-c mr-c force-pushed the output_secfile_required_from_container branch from de3736c to ce0c366 Compare July 1, 2023 02:03
@mr-c mr-c merged commit 0f7367b into main Jul 1, 2023
@mr-c mr-c deleted the output_secfile_required_from_container branch July 1, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required secondaryFiles outputs do not work in CWL CommandLineTools which run in Docker
1 participant