-
-
Notifications
You must be signed in to change notification settings - Fork 232
adding warning when default docker container is used on Windows #492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding warning when default docker container is used on Windows #492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test, please :-)
@mr-c I need a little help here. We need a test to check that if default container is used on windows, a warning should be given. Although on local system I can test and verify this behavior but since this behavior is |
No worries, how about a mock object?
https://en.wikipedia.org/wiki/Mock_object
Pe 25 iul. 2017 10:05 p.m., "Kapil kumar" <[email protected]> a
scris:
… @mr-c <https://github.com/mr-c> I need a little help here. We need a test
to check that if default container is used on windows, a warning should be
given. Although on local system I can test and verify this behavior but
since this behavior is windows with docker specific, how should we test
it in our CI.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#492 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABROCLgov0B3CIQq7TMk_mGwhIpN2RQ8ks5sRkqEgaJpZM4OgK69>
.
|
…ainer is used on windows
77ae895
to
7b5f82a
Compare
Hi @mr-c I added a test using mock object as suggested by you. That was something new for me. 😄 Can you review it. |
Huzzah -- thanks! |
referencing issue #469