Skip to content

adding warning when default docker container is used on Windows #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kapilkd13
Copy link
Contributor

referencing issue #469

Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test, please :-)

@kapilkd13
Copy link
Contributor Author

@mr-c I need a little help here. We need a test to check that if default container is used on windows, a warning should be given. Although on local system I can test and verify this behavior but since this behavior is windows with docker specific, how should we test it in our CI.

@mr-c
Copy link
Member

mr-c commented Jul 25, 2017 via email

@kapilkd13 kapilkd13 force-pushed the defaultcontainerWarning branch 2 times, most recently from 77ae895 to 7b5f82a Compare July 26, 2017 12:35
@kapilkd13
Copy link
Contributor Author

Hi @mr-c I added a test using mock object as suggested by you. That was something new for me. 😄 Can you review it.

@mr-c mr-c merged commit da4930f into common-workflow-language:master Jul 26, 2017
@mr-c
Copy link
Member

mr-c commented Jul 26, 2017

Huzzah -- thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants