-
-
Notifications
You must be signed in to change notification settings - Fork 232
Removing unnecessary warning due to generation field #525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mr-c
merged 4 commits into
common-workflow-language:master
from
kapilkd13:generation_warn
Aug 17, 2017
Merged
Removing unnecessary warning due to generation field #525
mr-c
merged 4 commits into
common-workflow-language:master
from
kapilkd13:generation_warn
Aug 17, 2017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output will be something like this
|
LGTM, I'd like @tetron to verify this |
tetron
reviewed
Aug 15, 2017
cwltool/main.py
Outdated
@@ -915,6 +915,9 @@ def locToPath(p): | |||
|
|||
visit_class(out, ("File", "Directory"), locToPath) | |||
|
|||
# Unsetting the Generation fron final output object | |||
visit_class(out,("File"), MutationManager().unset_generation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want ("File",) to make it a 1-item tuple.
tetron
approved these changes
Aug 15, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
7d30fa1
to
d4b76c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setting generation field after schema validation and removing this generation field from the final output.
closes #382