Do not evaluate expressions with self if input object is null
#630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anton-khodak
force-pushed
the
fix/js-expr-for-null-inputs
branch
2 times, most recently
from
f00507f to
daaaa53
Compare
|
@anton-khodak Thanks! Can you make a conformance test for this in the main CWL repo so we can confirm that this is the correct behavior? Once that is approved then we can merge this |
|
6 conformance tests fail: https://ci.commonwl.org/job/cwltool-pr-conformance-multiver/948/testReport/ |
|
@anton-khodak Looks like someone needs to add |
|
@anton-khodak or rather, if no |
|
Jenkins, test this please |
1 similar comment
|
Jenkins, test this please |
This was referenced Jan 30, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #621