Skip to content

Fix #628 and improve parameter reference error messages #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 2, 2018

Conversation

ThomasHickman
Copy link
Member

This fixes #648 and makes the error messages for parameter references better (as referenced in the commit). I've also cleaned up the code which I've changed, to make it easier for other people to edit.

@cwl-bot
Copy link

cwl-bot commented Feb 9, 2018

Can one of the admins verify this patch?

@mr-c
Copy link
Member

mr-c commented Feb 9, 2018

Jenkins, add to test list

@mr-c
Copy link
Member

mr-c commented Feb 10, 2018

Jenkins, add to testlist

@mr-c
Copy link
Member

mr-c commented Feb 10, 2018

Running this with the example file from #648 (comment)

$ cwltool --validate expr_fail.cwl 
/home/michael/cwltool/env/bin/cwltool 1.0.20180210112813
/home/michael/cwltool/env/bin/cwltool 1.0.20180210112813
Resolved 'expr_fail.cwl' to 'file:///home/michael/cwltool/expr_fail.cwl'
Resolved 'expr_fail.cwl' to 'file:///home/michael/cwltool/expr_fail.cwl'
Tool definition is valid
Tool definition is valid

@ThomasHickman
Copy link
Member Author

^ is this unexpected output, or are you just verifying that this PR works?

@mr-c mr-c merged commit 9eeff23 into common-workflow-language:master Mar 2, 2018
@mr-c
Copy link
Member

mr-c commented Mar 2, 2018

Thanks again @ThomasHickman !

@ThomasHickman ThomasHickman deleted the fix-648 branch March 12, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression-like valid javascript fails
3 participants