Skip to content

Set --tmp-outdir-prefix on MacOS to be under the shared volume by default #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2018
Merged

Set --tmp-outdir-prefix on MacOS to be under the shared volume by default #670

merged 1 commit into from
Feb 23, 2018

Conversation

anton-khodak
Copy link
Member

@anton-khodak anton-khodak commented Feb 23, 2018 •
edited
Loading

closes #657 , closes #328, closes #258

mr-c
mr-c reviewed Feb 23, 2018
View reviewed changes
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in principle, you have 2 failing conformance tests.

@anton-khodak
Copy link
Member Author

anton-khodak commented Feb 23, 2018 •
edited
Loading

Looks like these two tests aren't consistent, here's a previous successful build for practically the same code (with a cosmetic change that obviously didn't affect the results) https://ci.commonwl.org/job/cwltool-pr-conformance-multiver/1050

@anton-khodak
Copy link
Member Author

Jenkins, test this please

@anton-khodak anton-khodak merged commit 92abb4e into master Feb 23, 2018
@anton-khodak anton-khodak deleted the fix/macos-tmpdir branch February 23, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-c mr-c mr-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@anton-khodak @mr-c