Skip to content

Optional skip_schemas #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2017
Merged

Optional skip_schemas #115

merged 1 commit into from
Jun 23, 2017

Conversation

stain
Copy link
Member

@stain stain commented Jun 23, 2017

Fixes common-workflow-language/cwltool#433

I would ideally also then want to remove "Did you include a $schemas section" from validate.py - but we don't know if the user want to do a strict vs non-strict.

@mr-c
Copy link
Member

mr-c commented Jun 23, 2017

(env) mcrusoe@mrcdev:~/common-workflow-language$ ./run_test.sh RUNNER=cwltool EXTRA=--skip-schemas
--- Running conformance test v1.0 on /home/mcrusoe/cwltool/env/bin/cwltool ---
/home/mcrusoe/cwltool/env/bin/cwltool 1.0.20170623150402
Test [87/87] All tests passed

All tool tests succeeded

I am pleasantly surprised that this didn't fail any tests!

@mr-c mr-c merged commit d370602 into master Jun 23, 2017
@mr-c mr-c deleted the skip_schemas branch June 23, 2017 15:27
@MarkRobbo
Copy link
Member

@mr-c Double edged sword though! Maybe that indicates that some tests should be there for add_schemas 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants