Skip to content

Clarity in "Running Tools Inside Docker" #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
petehague opened this issue Oct 12, 2018 · 2 comments
Closed

Clarity in "Running Tools Inside Docker" #119

petehague opened this issue Oct 12, 2018 · 2 comments

Comments

@petehague
Copy link

In the section on Docker, the example uses a node.js container executing the command 'node'

If the reader is unfamiliar with node.js, it is not immediately obvious that 'node' is a valid command within the container, and not referring to the container itself.

Could you please consider changing the example slightly - perhaps having a more clearly recognisable 'echo' command executed in the container.

@AlexanderFillbrunn
Copy link

I agree. Especially the sentence

baseCommand: node tells CWL that we will be running this command in a container.

is not correct. You could also run node outside of a container.

@smyja
Copy link
Contributor

smyja commented Oct 20, 2022

@mr-c mr-c closed this as completed Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants