-
-
Notifications
You must be signed in to change notification settings - Fork 67
Fix emphasize-lines with runcmd #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(worth going around the user guide when reviewing it too... it shouldn't break anything, but you never know! 👍 ) |
Huh, I just tried re-running everything after cleaning my environment, and it failed to find the lines for (venv) kinow@ranma:~/Development/python/workspace/user_guide/src/_includes/cwl/inputs$ cwltool record.cwl record-job1.yml
INFO /home/kinow/Development/python/workspace/user_guide/venv/bin/cwltool 3.1.20221008225030
INFO Resolved 'record.cwl' to 'file:///home/kinow/Development/python/workspace/user_guide/src/_includes/cwl/inputs/record.cwl'
ERROR Workflow error, try again with --debug for more information:
Invalid job input record:
record-job1.yml:1:1: the `dependent_parameters` field is not valid because
missing required field `itemB` Something changed somewhere (either in the example, or in |
I think it's fixed now. Let me know if the build passes for you now @swzCuroverse 👍 |
Let me see if it works for me :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - It isn't working for me. I went to the fix-emphasize-lines-runcmd branch and ran make html, and I still see the same errors. I verified that I had the correct branch by comparing the changes listed here and the files I have in my branch. Still no luck. Let me see if some old html is hanging about and that is causing an issue.
Side note -- these are my configurations if different than yours MdParserConfig(commonmark_only=False, gfm_only=False, enable_extensions=['colon_fence', 'deflist', 'substitution', 'replacements'], disable_syntax=[], all_links_external=False, url_schemes=('http', 'https', 'mailto', 'ftp'), ref_domains=None, highlight_code_blocks=True, number_code_blocks=[], title_to_header=False, heading_anchors=4, heading_slug_func=None, footnote_transition=True, words_per_minute=200, sub_delimiters=('{', '}'), linkify_fuzzy_links=True, dmath_allow_labels=True, dmath_allow_space=True, dmath_allow_digits=True, dmath_double_inline=False, update_mathjax=True, mathjax_classes='tex2jax_process|mathjax_process|math|output_area')
and sphinx versions:
sphinx==5.2.3
sphinx-autobuild==2021.3.14
sphinx-reredirects==0.1.1
sphinxcontrib-applehelp==1.0.2
sphinxcontrib-devhelp==1.0.2
sphinxcontrib-htmlhelp==2.0.0
sphinxcontrib-jsmath==1.0.1
sphinxcontrib-qthelp==1.0.3
sphinxcontrib-runcmd==0.2.0
sphinxcontrib-serializinghtml==1.1.5
Hi @swzCuroverse , do you still have the exact same error? Could you try:
Are these from
Our sphinx versions are the same 👍 so I think we can rule that out. Thanks @swzCuroverse ! |
a1d10b4
to
8a15eba
Compare
@kinow , I removed the _build and make sure I am up to date with the latest main branch, and I still get the error: Let me re-clone and see if that fixes the issue. make html Warning, treated as error: |
I recloned a new version and it still breaks for me. make html |
Maybe there is something different in your config? |
@swzCuroverse I was able to get this to work after doing this:
|
Closes #269
@swzCuroverse this PR changes should fix the
emphasize-lines
and hopefullymake html
works for you from this branch. Could you review it, please?@mr-c told you it was one of those annoying issues that requires a single line to fix, but you spend way too long figuring out which line to change 😆
The issue was identified in this pull request review by @mr-c : #246 (comment)
The comment was on the
troubleshooting.md
file. Here's this file rendered on my local environment (reviewers can use the RTD preview 👇):