Skip to content

Update docker image for Java #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 26, 2017
Merged

Update docker image for Java #69

merged 2 commits into from
Dec 26, 2017

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Dec 25, 2017

This request updates deprecated Java docker image java:7-jdk to openjdk:9.0.1-11-slim.

I used openjdk:9.0.1-11-slim as the latest image.

  • I used slim family for smaller size docker images to make CI faster.
  • I used 9.0.1-11-slim tag because:
    • Java 9 is the latest released version of Java. There are no reason to use older release.
    • Other tags such as 9, 9.0, 9.0.1 are not appropriate for reproducibility. They can be implicitly replaced with minor released versions.

See also: #61

@mr-c mr-c merged commit 880c679 into common-workflow-language:gh-pages Dec 26, 2017
@mr-c
Copy link
Member

mr-c commented Dec 26, 2017

Thank you!

@tom-tan tom-tan deleted the fix-docker-for-java branch December 30, 2017 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-c mr-c mr-c approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-tan @mr-c