Skip to content

16-file-formats: fix output name record #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 17, 2018

Conversation

jirikuncar
Copy link
Contributor

@jirikuncar jirikuncar commented Jan 15, 2018

@manabuishii
Copy link
Contributor

When I check this PullRequest.

I wonder this 16's sample actually using this section.

bamstats_report:
    class: File
    path: /tmp/bamstats_report.zip

This pull request version

report:
    class: File
    path: /tmp/bamstats_report.zip

Both are same result and always output.txt is created.

I think this is a result of

stdout: output.txt

outputs:
  report:
    type: stdout
    format: edam:format_1964
    label: A text file that contains a line count

and result of cwltool looks almost same
(sample.yml is using this pull request version)

$ cwltool metadata_example.cwl sample.yml 
/home/manabu/.local/bin/cwltool 1.0.20180111185617
Resolved 'metadata_example.cwl' to 'file:///home/manabu/.ghq/github.com/common-workflow-language/user_guide/_includes/cwl/16-file-formats/metadata_example.cwl'
[job metadata_example.cwl] /tmp/tmpr5yd6_$ wc \
    -l \
    /tmp/tmp5exIdV/stgd76b2bc9-72c6-47bc-b1b6-ecc3689b6174/file-formats.bam > /tmp/tmpr5yd6_/output.txt
[job metadata_example.cwl] completed success
{
    "report": {
        "format": "http://edamontology.org/format_1964", 
        "checksum": "sha1$6cec3ea6fefaa506aca999b8e2d09a004c4a6358", 
        "basename": "output.txt", 
        "location": "file:///home/manabu/.ghq/github.com/common-workflow-language/user_guide/_includes/cwl/16-file-formats/output.txt", 
        "path": "/home/manabu/.ghq/github.com/common-workflow-language/user_guide/_includes/cwl/16-file-formats/output.txt", 
        "class": "File", 
        "size": 78
    }
}
Final process status is success

output.txt is

13698 /tmp/tmp5exIdV/stgd76b2bc9-72c6-47bc-b1b6-ecc3689b6174/file-formats.bam

@manabuishii
Copy link
Contributor

Related to #73

@ghost
Copy link

ghost commented Oct 17, 2018

@manabuishii @jirikuncar I'm not familiar with this option - I'm assuming sample.yml is the input (job) file. What effect does specifying the path to an output file have? Does it govern the name and location of the output file - overriding the default location a runner puts it in? Thanks!

@mr-c
Copy link
Member

mr-c commented Oct 17, 2018

@kaushik-work Thanks for the ping. This was a dockstore-ism that slipped in. For reasons I don't understand, the put the outputs also in the input object. That is not standard CWL.

@mr-c mr-c merged commit befb17c into common-workflow-language:gh-pages Oct 17, 2018
@mr-c mr-c mentioned this pull request Oct 17, 2018
@jirikuncar jirikuncar deleted the patch-1 branch October 25, 2018 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants