Skip to content

Fix an example of Section7 not to use side effect #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 20, 2018
Merged

Fix an example of Section7 not to use side effect #92

merged 4 commits into from
Feb 20, 2018

Conversation

tom-tan
Copy link
Member

@tom-tan tom-tan commented Feb 20, 2018 •
edited by mr-c
Loading

This request partially addresses #37 and #62.

I confirmed it passes conformance tests in my local machine.

@tom-tan
Copy link
Member Author

tom-tan commented Feb 20, 2018

It fails conformance tests due in unrelated place (section 17).
I guess cwltool master introduces regressions...

mr-c added 2 commits February 20, 2018 11:27
@mr-c
Use released versions of cwltool, cwltest
4b156f4 
Add html5lib for schema.org annotations
@mr-c
Merge pull request #93 from common-workflow-language/use_released_deps
e35459a 
Use released versions of cwltool, cwltest
@mr-c
Copy link
Member

mr-c commented Feb 20, 2018

Ah, it was missing the html5lib dependency. I've fixed that in #93

By the way, @tom-tan , can you make your future branches in this repository? That would make collaboration even easier. You have permissions to push new branches to any common-workflow-language repository :-)

@mr-c mr-c merged commit 8838f3e into common-workflow-language:gh-pages Feb 20, 2018
@mr-c
Copy link
Member

mr-c commented Feb 20, 2018

@tom-tan Thanks!

@tom-tan tom-tan deleted the fix-side-effects-07 branch February 21, 2018 02:34
@tom-tan
Copy link
Member Author

tom-tan commented Feb 21, 2018

By the way, @tom-tan , can you make your future branches in this repository?

OK, I will do that from the next PR!

@tom-tan tom-tan mentioned this pull request Feb 21, 2018
Open
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tom-tan @mr-c