Ability to execute in parallel (GDB) #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
commented
Sep 16, 2024
Comment on lines
+39
to
+42
| # make sure all output is flushed | ||
| # time.sleep(.005) | ||
| self.base_gdb_instance.send((("",), {"timeout_sec": 60})) | ||
| raw_result += self.base_gdb_instance.recv() |
There was a problem hiding this comment.
Do we need this?
I observed that we do not have this in the run_single_special_command function.
There was a problem hiding this comment.
I think this is a remaining of the previous efforts to capture GDB response where we listened for stdout output. I think this is no longer needed since we are using the other approach based on the IoManager.
Comment on lines
+101
to
+104
| try: | ||
| parsed_dict = json.loads(processed_output) | ||
| except json.JSONDecodeError: | ||
| parsed_dict = processed_output |
There was a problem hiding this comment.
This change is related to the JSONDecodeError we were talking about.
Without this change, I am getting the JSON error.
There was a problem hiding this comment.
Maybe there are certain cases where the processed_output is not in the correct format and json.loads fails to parse it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #27
Test with
Previously it would take ~11 secs. Now it takes ~6 secs.