Skip to content

using RichLog instead of ScrollView for TextScrollView #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2024
Merged

using RichLog instead of ScrollView for TextScrollView #32

merged 1 commit into from
Oct 2, 2024

Conversation

Vipul-Cariappa
Copy link
Contributor

@Vipul-Cariappa Vipul-Cariappa commented Oct 2, 2024 •
edited
Loading

reduces the code
better UI
enables vertical and horizontal scrolls

BEFORE:
Screenshot from 2024-10-02 16-21-44

AFTER:
image

Please look at the horizontal scroll bars.
Also, look at the misalignment I have circled.

@mvassilev
Copy link
Collaborator

Well done!

@vgvassilev
Copy link
Contributor

Can you attach screenshots of before and after? Maybe improve the commit message, too?

@Vipul-Cariappa
Copy link
Contributor Author

Can you attach screenshots of before and after?

Done. I have edited the PR description with the screenshots.

Maybe improve the commit message, too?

I don't know what I should change it to.

@vgvassilev
Copy link
Contributor

Can you attach screenshots of before and after?

Done. I have edited the PR description with the screenshots.

Maybe improve the commit message, too?

I don't know what I should change it to.

Something that has complete sentences? And explaining to a person without knowledge what was done.

@Vipul-Cariappa
using RichLog widget instead of ScrollView for diff_areas (`Tex…
1300669 
…tScrollView`)

This change lets use remove the code related to rendering each line of text manually as it is now handled by `RichLog`.
This also enables horizontal scroll.
@Vipul-Cariappa
Copy link
Contributor Author

Something that has complete sentences? And explaining to a person without knowledge what was done.

I have made the suggested changes. Please let me know if it requires additional changes.

@vgvassilev vgvassilev merged commit 9952c1c into compiler-research:main Oct 2, 2024
@Vipul-Cariappa Vipul-Cariappa deleted the widgets branch October 2, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vipul-Cariappa @mvassilev @vgvassilev