Skip to content

feat: reorg as package #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

henryiii
Copy link
Contributor

Making this a package.

@vgvassilev
Copy link
Contributor

The package name now is ours. Can we move forward with this PR?

@henryiii
Copy link
Contributor Author

henryiii commented Feb 8, 2025

Sure, I can rebase Monday.

@vgvassilev
Copy link
Contributor

@henryiii ping.

@henryiii
Copy link
Contributor Author

Sorry, I forgot, will do this today. It's always okay to ping me. :)

Signed-off-by: Henry Schreiner <[email protected]>
@henryiii henryiii force-pushed the henryiii/feat/pkg branch from 974dd77 to 288c0be Compare March 10, 2025 19:25
@henryiii henryiii marked this pull request as ready for review March 10, 2025 21:52
@vgvassilev vgvassilev requested a review from mvassilev March 11, 2025 14:12
@vgvassilev
Copy link
Contributor

@henryiii, what is the next step after this PR gets merged? We release and then upload the repository in the pipy website?

@henryiii
Copy link
Contributor Author

I can commit a GitHub Actions with a release workflow as a followup. Then when you make a release, it will be pushed to PyPI. You'll need to add this repo and the workflow I add to PyPI's trusted publishing config.

@henryiii
Copy link
Contributor Author

@vgvassilev
Copy link
Contributor

(The guide is at https://learn.scientific-python.org/development/guides/gha-pure/ )

Thank you. @Vipul-Cariappa perhaps that's what we should try doing.

@vgvassilev vgvassilev merged commit 42a7825 into compiler-research:main Mar 11, 2025
@mvassilev
Copy link
Collaborator

Hi @henryiii , when I try using idd via:
python -m idd -c gdb -ba -ra `

I get the following error:
No module named idd

When I execute the above command when in the src folder I get:
Traceback (most recent call last): File "<frozen runpy>", line 198, in _run_module_as_main File "<frozen runpy>", line 88, in _run_code File "/home/mvassilev/workspace/idd/src/idd/__main__.py", line 1, in <module> from src.cli import main ModuleNotFoundError: No module named 'src'

Could you please assist me how to run it?

@henryiii
Copy link
Contributor Author

henryiii commented Mar 13, 2025

Sure, you need to run pip install -e .. That will enable you do run it from anywhere. After that either python -m idd or idd will work.

Vipul-Cariappa added a commit to Vipul-Cariappa/idd that referenced this pull request Mar 17, 2025
Previously `disable_assembly`, `Debugger` & `disable_registers` were globals.
mvassilev pushed a commit that referenced this pull request Mar 17, 2025
Previously `disable_assembly`, `Debugger` & `disable_registers` were globals.
@vgvassilev vgvassilev mentioned this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants