[CD] Upload package to PyPI when creating a release #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While developing, we can test out changes without pip install
mvassilev
approved these changes
Mar 20, 2025
|
@henryiii, can you take a look? |
|
@henryiii ping. |
henryiii
approved these changes
Mar 25, 2025
.github/workflows/release.yml
Outdated
| path: dist | ||
|
|
||
| - name: Generate artifact attestation for sdist and wheel | ||
| uses: actions/[email protected] |
There was a problem hiding this comment.
If you'd like a little less maintenance, you can use v2 instead of v2.2.3. Up to you.
.github/workflows/release.yml
Outdated
| permissions: | ||
| id-token: write | ||
| attestations: write | ||
| contents: read |
There was a problem hiding this comment.
This one's default, you don't need it, though it doesn't hurt.
There was a problem hiding this comment.
Sorry, I just meant the contents: read line, not the entire block.
There was a problem hiding this comment.
I guess it's not obvious that I was commenting on a single line, GitHub shows context when you do one line.
There was a problem hiding this comment.
Fixed it. Could you please have a look at it again.
mvassilev
pushed a commit
that referenced
this pull request
Mar 29, 2025
* enable running the script without installing as a package While developing, we can test out changes without pip install * [CD] Upload package to PyPI when creating a release * fix according to code review * fix permissions
vgvassilev
pushed a commit
that referenced
this pull request
Apr 10, 2025
* Fix exception occuring in case of illigal stack_frame string. * Refactor to use pty for capturing output. * [CD] Upload package to PyPI when creating a release (#48) * enable running the script without installing as a package While developing, we can test out changes without pip install * [CD] Upload package to PyPI when creating a release * fix according to code review * fix permissions * Fix buffer. * Include stdout and stdin as subwindows. * Add debugee stdout and stdin windows. * Intercept gdb output even if it appears with delays. * Remove " as they may break the json format. * Fix parsing of the speacial commands to follow the new approach. * Disable not implemented function call. * Reduce timeout so that commands are completed quickley. * Add default values. * Use full path of the file. * Use parallel and non blocking calls to speed command execution. * Fix issuing single commands * Fix receiving of debuggee output. * Remove " from the stack, args and locals output. Prevents from violating the json generated. * Disable debuginfod. * Ensure debuggee output is flused before a ywrite. * Disable stdout flush as it discards debuggee stdout. * remove additional panels used while developing (#58) --------- Co-authored-by: Vipul Cariappa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vgvassilev, You will first need to follow the instructions at https://docs.pypi.org/trusted-publishers/creating-a-project-through-oidc/ . Make sure the repo/package/workflow names match.
Then merge this PR.
And create a release.
Hopefully, everything goes as expected.
Requesting review from @mvassilev and @henryiii.