Skip to content

[wip] Fix all linter issues with idd picked up by ruff #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mcbarton
Copy link

The objective of this PR will be to fix all the linter issues with idd picked up by ruff. Before this PR ruff picked the up the following issues

ruff check --statistics 
20	F401	[*] unused-import
17	E711	[ ] none-comparison
13	F841	[ ] unused-variable
11	F405	[ ] undefined-local-with-import-star-usage
 5	E401	[*] multiple-imports-on-one-line
 4	E713	[*] not-in-test
 2	E722	[ ] bare-except
 2	F403	[ ] undefined-local-with-import-star
 2	F811	[ ] redefined-while-unused
Found 76 errors.

The first commit is the changes done by executing ruff check --fix on the repo to automatically fix F401, E401 and E713 . Each subsequent commit will fix one of the rules that is left. Once all rules have been fixed I will add a workflow which run the ruff linter over subsequent PRs .

@mcbarton
Copy link
Author

mcbarton commented Apr 19, 2025

Down to the following

ruff check --statistics
10	F841	unused-variable
 1	F811	redefined-while-unused

To see where these are you can either remove the --statistsics flag or run

ruff check --select F841

to see where a particular rule is broken (example above is for F841 rule).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant