Skip to content

Feat: first-pass index.html #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 15, 2022
Merged

Feat: first-pass index.html #5

merged 8 commits into from
Jun 15, 2022

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Jun 3, 2022

Closes #2

Summary

Adds a basic index.html file which mirrors our business cards with Compiler branding. Currently not utilizing any Jekyll features yet.

@angela-tran angela-tran self-assigned this Jun 3, 2022
@angela-tran
Copy link
Member Author

I might put this back into draft so that I can add media queries for mobile/tablet breakpoints in our CSS.

@netlify
Copy link

netlify bot commented Jun 8, 2022

Deploy Preview for compilerla ready!

Name Link
🔨 Latest commit 982bc24
🔍 Latest deploy log https://app.netlify.com/sites/compilerla/deploys/62aa0e5584a9d6000851cb19
😎 Deploy Preview https://deploy-preview-5--compilerla.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

thekaveman
thekaveman previously approved these changes Jun 8, 2022
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the C_ logo as a favicon please?

@thekaveman thekaveman dismissed their stale review June 8, 2022 18:08

Accidentally approved

@vykster
Copy link
Member

vykster commented Jun 8, 2022

@thekaveman we actually have a favicon!

google link

@AnthonyRollins
Copy link
Member

AnthonyRollins commented Jun 9, 2022

@angela-tran

Invert colors to mirror future website designs

I am not finding the white logo with the teal line in the branding folders, it should be the one in the drive link above, but it appears to be the wrong file.

Change email link [email protected] color and text decoration

  • Change on-hover transition to green #92B252
  • Add text-decoration: underline

Adding a underline is important to accessibility

@angela-tran
Copy link
Member Author

@AnthonyRollins Thank you for the detailed list of changes! I was wondering where you found the values for #00B3CA as teal and #92B252 as green.

I was referencing a PDF in Google Drive named Compiler Style Guide V2.pdf, but I'm not sure if that's the "official"/finalized resource. It has #01B4CB as teal and #88B440 as green.

Here's a screenshot of the page I was looking at... interestingly though, some colors in the PDF don't exactly match what's listed (see teal as an example).

@thekaveman
Copy link
Member

@AnthonyRollins here's a test comment to see if it pings you in Slack

@AnthonyRollins
Copy link
Member

AnthonyRollins commented Jun 10, 2022

@angela-tran
I pulled the colors from the Figma designs: https://www.figma.com/file/fkRyBpWGDyaBh1kzaXIljo/Compiler-website?node-id=0%3A1. I would imagine the PDF brand guide has the color codes we should be using.

@angela-tran
Copy link
Member Author

We're self-hosting the fonts since there isn't any performance gain to using CDN versions
https://wicki.io/posts/2020-11-goodbye-google-fonts/

Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@angela-tran angela-tran merged commit 23fbe78 into main Jun 15, 2022
@angela-tran angela-tran deleted the feat/jekyll-site branch June 15, 2022 19:46
@angela-tran angela-tran mentioned this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create initial Jekyll site structure and theme
4 participants