Skip to content

Build swift-inspect in the toolchain workflow. #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2023
Merged

Build swift-inspect in the toolchain workflow. #557

merged 1 commit into from
Jun 5, 2023

Conversation

hjyamauchi
Copy link
Collaborator

Build swift-inspect under the installer setup at the end like swift-format.

@hjyamauchi
Copy link
Collaborator Author

The standalone workflow has been tested https://github.com/hjyamauchi/swift-build/actions/runs/5149995509
The toolchain workflow is being tested https://github.com/thebrowsercompany/swift-build/actions/runs/5150014765 but it may time out.

compnerd
compnerd requested changes Jun 2, 2023
View reviewed changes
@hjyamauchi
Copy link
Collaborator Author

The workflow worked (except that the release step failed due to the release tag conflict with the previous run, which I think is expected) at https://github.com/thebrowsercompany/swift-build/actions/runs/5159007140

@hjyamauchi hjyamauchi force-pushed the swift-inspect-2 branch 2 times, most recently from a0abdad to 1b2aedf Compare June 3, 2023 01:35
compnerd
compnerd approved these changes Jun 3, 2023
View reviewed changes
Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hjyamauchi hjyamauchi force-pushed the swift-inspect-2 branch 4 times, most recently from 0b97399 to 5d1b38d Compare June 3, 2023 02:20
@hjyamauchi
Copy link
Collaborator Author

OK, done.
The standalone version was tested: https://github.com/hjyamauchi/swift-build/actions/runs/5161327228
The toolchain version is being tested: https://github.com/thebrowsercompany/swift-build/actions/runs/5161378872

@compnerd
Copy link
Owner

compnerd commented Jun 3, 2023

Why does swift_inspect and swift_format show up as a single job? I think that we should have them be separate jobs to allow them to execute in parallel.

@hjyamauchi
Copy link
Collaborator Author

Not obvious to me why. They don't look depending on each other. Also it's odd that they are failing because of the .exe file not being found. I think the upload-artfact doesn't work with symlinks but it worked for swift-format in the previous runs?

@hjyamauchi
Copy link
Collaborator Author

Updated to fix the .exe path.
Kicked off another run: https://github.com/thebrowsercompany/swift-build/actions/runs/5165466307

@hjyamauchi hjyamauchi force-pushed the swift-inspect-2 branch 2 times, most recently from f65c233 to ed97da5 Compare June 4, 2023 05:16
@compnerd
Copy link
Owner

compnerd commented Jun 4, 2023

@hjyamauchi - mind rebasing the change?

@hjyamauchi
Copy link
Collaborator Author

Rebased. Testing at https://github.com/thebrowsercompany/swift-build/actions/runs/5173064838
It looks like using strategy/matrix makes the swift-format/swift-inspect jobs separate.

@compnerd compnerd merged commit ae0b568 into compnerd:main Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjyamauchi @compnerd